From d7f9474ed68f0f0bbb18bd44ed9811083284d869 Mon Sep 17 00:00:00 2001
From: Tomas Edwardsson <tommi@tommi.org>
Date: Mon, 22 Oct 2012 13:21:47 +0000
Subject: [PATCH 1/3] Added fahrenheit to celsius conversion

---
 check_apcext.pl/check_apcext.pl | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/check_apcext.pl/check_apcext.pl b/check_apcext.pl/check_apcext.pl
index 9fc254e..72f8306 100755
--- a/check_apcext.pl/check_apcext.pl
+++ b/check_apcext.pl/check_apcext.pl
@@ -14,6 +14,7 @@ use vars qw/ %opt /;
 use strict;
 
 sub getmasked_values ($$);
+sub f2c ($);
 
 if ($ARGV[0] =~ /(--help|-h|help)/ || !defined$ARGV[0]) {
 	&usage;
@@ -417,6 +418,12 @@ APC ACRC In-Row
 
 }
 
+sub f2c($) {
+	my $f = shift;
+
+	return ($f - 32) * (5/9);
+}
+
 sub getmasked_values ($$) {
 	my ($baseoid, $values) = @_;
 

From ae0968af02df92f1113f659721ded25a2026f37a Mon Sep 17 00:00:00 2001
From: Tomas Edwardsson <tommi@opensource.is>
Date: Mon, 22 Oct 2012 15:10:24 +0000
Subject: [PATCH 2/3] Fixed metric conversion for all mibs

---
 check_apcext.pl/check_apcext.pl | 29 +++++++++++++++++------------
 1 file changed, 17 insertions(+), 12 deletions(-)

diff --git a/check_apcext.pl/check_apcext.pl b/check_apcext.pl/check_apcext.pl
index 72f8306..33c7522 100755
--- a/check_apcext.pl/check_apcext.pl
+++ b/check_apcext.pl/check_apcext.pl
@@ -41,11 +41,11 @@ my %rpduamps;
 my %oids = ( 
 	'nbmstemp' => {
 		'label' => 'Temp',
-		'unit'	=> ($metric ? 'degC' : 'degF'),
+		'unit'	=> 'degF',
 		'oidbase' => '.1.3.6.1.4.1.5528.100.4.1.1.1',
 		'sensor_key' => 5,
 		'sensor_val' => 2,
-		'cdef'  => ($metric ? '$val * 0.1' : '($val * .18) + 32')
+		'$val * 0.1'
 		},
 	'nbmshum' => {
 		'label' => 'Humidity',
@@ -95,13 +95,13 @@ my %oids = (
 		},
 	'acscsupair' => {
 		'label' => 'Supply Air',
-		'unit'	=> 'F',
+		'unit'	=> 'degF',
 		'oid' 	=> '.1.3.6.1.4.1.318.1.1.13.3.4.1.2.8.0',
 		'cdef'  => '$val * .10'
 		},
 	'acscretair' => {
 		'label' => 'Return Air',
-		'unit'	=> 'F',
+		'unit'	=> 'degF',
 		'oid' 	=> '.1.3.6.1.4.1.318.1.1.13.3.4.1.2.10.0',
 		'cdef'  => '$val * .10'
 		},
@@ -112,19 +112,19 @@ my %oids = (
 		},
 	'acscracktemp' => {
 		'label' => 'Rack Inlet Temp',
-		'unit'	=> 'F',
+		'unit'	=> 'degF',
 		'oid' 	=> '.1.3.6.1.4.1.318.1.1.13.3.4.1.2.6.0',
 		'cdef'  => '$val * .10'
 		},
 	'acsccondin' => {
 		'label' => 'Cond Inlet Temp',
-		'unit'	=> 'F',
+		'unit'	=> 'degF',
 		'oid' 	=> '.1.3.6.1.4.1.318.1.1.13.3.4.1.2.30.0',
 		'cdef'  => '$val * .10'
 		},
 	'acsccondout' => {
 		'label' => 'Cond Outlet Temp',
-		'unit'	=> 'F',
+		'unit'	=> 'degF',
 		'oid' 	=> '.1.3.6.1.4.1.318.1.1.13.3.4.1.2.28.0',
 		'cdef'  => '$val * .10'
 		},
@@ -152,19 +152,19 @@ my %oids = (
 		},
 	'acrcracktemp' => {
 		'label' => 'Rack Inlet Temp',
-		'unit'	=> 'F',
+		'unit'	=> 'degF',
 		'oid' 	=> '.1.3.6.1.4.1.318.1.1.13.3.2.2.2.6.0',
 		'cdef'  => '$val * .10'
 		},
 	'acrcsupair' => {
 		'label' => 'Supply Air',
-		'unit'	=> 'F',
+		'unit'	=> 'degF',
 		'oid' 	=> '.1.3.6.1.4.1.318.1.1.13.3.2.2.2.8.0',
 		'cdef'  => '$val * .10'
 		},
 	'acrcretair' => {
 		'label' => 'Return Air',
-		'unit'	=> 'F',
+		'unit'	=> 'degF',
 		'oid' 	=> '.1.3.6.1.4.1.318.1.1.13.3.2.2.2.10.0',
 		'cdef'  => '$val * .10'
 		},
@@ -183,13 +183,13 @@ my %oids = (
 		},
 	'acrcflenttemp' => {
 		'label' => 'Entering Fluid Temp',
-		'unit'	=> 'F',
+		'unit'	=> 'degF',
 		'oid' 	=> '.1.3.6.1.4.1.318.1.1.13.3.2.2.2.23.0',
 		'cdef'  => '$val * .10'
 		},
 	'acrcflrettemp' => {
 		'label' => 'Returning Fluid Temp',
-		'unit'	=> 'F',
+		'unit'	=> 'degF',
 		'oid' 	=> '.1.3.6.1.4.1.318.1.1.13.3.2.2.2.25.0',
 		'cdef'  => '$val * .10'
 		},
@@ -368,6 +368,11 @@ if ($param eq "rpduamps") {
 			$fval = $val;
 		}
 
+		if ($metric and $oids{$param}->{unit} eq 'degF') {
+			$oids{$param}->{unit} = 'degC';
+			$fval = sprintf("%.1f", f2c($fval));
+		}
+
 		if ($fval > $crit) {
         		$retval = 2;
 			$outmsg = "CRITICAL";

From 0b20e567de25b46f65c92c70f2a68eefb7ae8aa7 Mon Sep 17 00:00:00 2001
From: Tomas Edwardsson <tommi@tommi.org>
Date: Mon, 22 Oct 2012 16:02:25 +0000
Subject: [PATCH 3/3] Use the right value for the job nbmstemp

---
 check_apcext.pl/check_apcext.pl | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/check_apcext.pl/check_apcext.pl b/check_apcext.pl/check_apcext.pl
index 33c7522..e2e943c 100755
--- a/check_apcext.pl/check_apcext.pl
+++ b/check_apcext.pl/check_apcext.pl
@@ -44,8 +44,8 @@ my %oids = (
 		'unit'	=> 'degF',
 		'oidbase' => '.1.3.6.1.4.1.5528.100.4.1.1.1',
 		'sensor_key' => 5,
-		'sensor_val' => 2,
-		'$val * 0.1'
+		'sensor_val' => 9,
+		#'cdef' => '$val * 0.1'
 		},
 	'nbmshum' => {
 		'label' => 'Humidity',