LittleNellie
/
cipherscan
mirror of https://github.com/mozilla/cipherscan.git
2
0
Fork 0
Code Issues Releases Wiki Activity

Fixes instances of "SC2053: Quote the rhs of == in [[ ]] to prevent glob matching." 

In cipherscan line 469:
            if [[ ${known_certs[$cksum]} == $cert ]]; then
                                            ^-- SC2053: Quote the rhs of == in [[ ]] to prevent glob matching.

In cipherscan line 852:
        if [[ $selected == $prefered ]]; then
                           ^-- SC2053: Quote the rhs of == in [[ ]] to prevent glob matching.

In cipherscan line 915:
                if [[ "$cname" == ${curves[$id]} ]]; then
                                  ^-- SC2053: Quote the rhs of == in [[ ]] to prevent glob matching.
This commit is contained in:
Richard Soderberg 2015-09-05 04:35:58 -07:00
parent 24268e063e
commit b2521c8e42
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
cipherscan
View File

@ -503,7 +503,7 @@ test_cipher_on_target() {
local cksum=($(cksum <<<"$cert"))
# compare the values not just checksums so that eventual collision
# doesn't mess up results
if [[ ${known_certs[$cksum]} == $cert ]]; then
if [[ ${known_certs[$cksum]} == "$cert" ]]; then
if [[ -n "${current_certificates}" ]]; then
current_certificates+=","
fi
@ -886,7 +886,7 @@ test_serverside_ordering() {
serverside="True"
else
local selected=($result)
if [[ $selected == $prefered ]]; then
if [[ $selected == "$prefered" ]]; then
serverside="False"
else
serverside="True"
@ -949,7 +949,7 @@ test_curves() {
current_curves+="$cname"
fi
for id in "${!curves[@]}"; do
if [[ "$cname" == ${curves[$id]} ]]; then
if [[ $cname == "${curves[$id]}" ]]; then
# we know it's supported, remove it from set of offered ones
unset curves[$id]
break