From 6efb1a4afbabe2264bcaa0bcc8e0bb75924f457f Mon Sep 17 00:00:00 2001
From: Richard Soderberg <rsoderberg@gmail.com>
Date: Wed, 2 Sep 2015 21:21:14 -0700
Subject: [PATCH 01/14] replace if [ ... ] with if [[ ... ]]

Bash implements a backwards-compatible sh syntax for [ .. ], which
handles undef variables poorly. Use [[ .. ]] instead, to take full
advantage of the Bash improvements to the comparison brackets.
---
 cipherscan | 150 ++++++++++++++++++++++++++---------------------------
 1 file changed, 75 insertions(+), 75 deletions(-)

diff --git a/cipherscan b/cipherscan
index 8b539ae..7e23844 100755
--- a/cipherscan
+++ b/cipherscan
@@ -14,12 +14,12 @@ REALPATH=$(dirname $0)
 # make sure this doesn't error out when readlink -f isn't available (OSX)
 readlink -f $0 &>/dev/null && REALPATH=$(dirname $(readlink -f $0))
 OPENSSLBIN="${REALPATH}/openssl"
-if [ "$(uname -s)" == "Darwin" ]; then
+if [[ "$(uname -s)" == "Darwin" ]]; then
     OPENSSLBIN="${REALPATH}/openssl-darwin64"
 fi
 
 # cipherscan requires bash4, which doesn't come by default in OSX
-if [ ${BASH_VERSINFO[0]} -lt 4 ]; then
+if [[ ${BASH_VERSINFO[0]} -lt 4 ]]; then
     echo "Bash version 4 is required to run cipherscan."
     echo "Please upgrade your version of bash (ex: brew install bash)."
     exit 1
@@ -28,9 +28,9 @@ fi
 # test that timeout or gtimeout (darwin) are present
 TIMEOUTBIN="$(which timeout)"
 
-if [ "$TIMEOUTBIN" == "" ]; then
+if [[ "$TIMEOUTBIN" == "" ]]; then
     TIMEOUTBIN="$(which gtimeout)"
-    if [ "$TIMEOUTBIN" == "" ]; then
+    if [[ "$TIMEOUTBIN" == "" ]]; then
         echo "neither timeout nor gtimeout are present. install coreutils with {apt-get,yum,brew} install coreutils"
         exit 1
     fi
@@ -48,15 +48,15 @@ if [[ -e $(dirname $0)/openssl.cnf ]]; then
 fi
 
 # find a list of trusted CAs on the local system, or use the provided list
-if [ -z "$CACERTS" ]; then
+if [[ -z "$CACERTS" ]]; then
     for f in /etc/pki/tls/certs/ca-bundle.crt /etc/ssl/certs/ca-certificates.crt; do
-        if [ -e "$f" ]; then
+        if [[ -e "$f" ]]; then
             CACERTS="$f"
             break
         fi
     done
 fi
-if [ ! -e "$CACERTS" ]; then
+if [[ ! -e "$CACERTS" ]]; then
     CACERTS="$(dirname $0)/ca-bundle.crt"
 fi
 
@@ -192,13 +192,13 @@ EXAMPLES: $0 -starttls xmpp jabber.ccc.de:5222
 }
 
 verbose() {
-    if [ $VERBOSE != 0 ]; then
+    if [[ $VERBOSE != 0 ]]; then
         echo "$@" >&2
     fi
 }
 
 debug(){
-    if [ $DEBUG == 1 ]; then
+    if [[ $DEBUG == 1 ]]; then
         echo Debug: "$@" >&2
 	set -evx
     fi
@@ -416,7 +416,7 @@ test_cipher_on_target() {
         # sslv2 client hello doesn't support SNI extension
         # in SSLv3 mode OpenSSL just ignores the setting so it's ok
         # -status exception is ignored in SSLv2, go figure
-        if [ "$tls_version" == "-ssl2" ]; then
+        if [[ "$tls_version" == "-ssl2" ]]; then
             if [[ "$sslcommand" =~ (.*)(-servername\ [^ ]*)(.*) ]]; then
                 cmnd="${BASH_REMATCH[1]} ${BASH_REMATCH[3]}"
             else
@@ -447,7 +447,7 @@ test_cipher_on_target() {
             # compare the values not just checksums so that eventual collision
             # doesn't mess up results
             if [[ ${known_certs[$cksum]} == $cert ]]; then
-                if [ -n "${current_certificates}" ]; then
+                if [[ -n "${current_certificates}" ]]; then
                     current_certificates+=","
                 fi
                 current_certificates+="\"${cert_checksums[$cksum]}\""
@@ -498,7 +498,7 @@ test_cipher_on_target() {
                 fi
             fi
             # save the sha sum for reporting
-            if [ -n "${current_certificates}" ]; then
+            if [[ -n "${current_certificates}" ]]; then
                 current_certificates+=","
             fi
             current_certificates+="\"${sha256sum}\""
@@ -515,20 +515,20 @@ test_cipher_on_target() {
             verbose "connection successful; protocol: $current_protocol, cipher: $current_cipher, previous cipher: $previous_cipher"
         fi
         # handling of TLSv1.2 only cipher suites
-        if [ ! -z "$previous_cipher" ] && [ "$previous_cipher" != "$current_cipher" ] && [ "$current_cipher" != "0000" ]; then
+        if [[ ! -z "$previous_cipher" ]] && [[ "$previous_cipher" != "$current_cipher" ]] && [[ "$current_cipher" != "0000" ]]; then
             unset protocols
         fi
         previous_cipher=$current_cipher
 
         # connection succeeded, add TLS version to positive results
-        if [ -z "$protocols" ]; then
+        if [[ -z "$protocols" ]]; then
             protocols=$current_protocol
         else
             protocols="$protocols,$current_protocol"
         fi
         cipher=$current_cipher
         pfs=$current_pfs
-        [ -z $pfs ] && pfs="None"
+        [[ -z $pfs ]] && pfs="None"
         pubkey=$current_pubkey
         sigalg=$current_sigalg
         trusted=$current_trusted
@@ -539,13 +539,13 @@ test_cipher_on_target() {
     done
     # if cipher is empty, that means none of the TLS version worked with
     # the current cipher
-    if [ -z "$cipher" ]; then
+    if [[ -z "$cipher" ]]; then
         verbose "handshake failed, no ciphersuite was returned"
         result='ConnectionFailure'
         return 2
 
     # if cipher contains NONE, the cipher wasn't accepted
-    elif [ "$cipher" == '(NONE)  ' ]; then
+    elif [[ "$cipher" == '(NONE)  ' ]]; then
         result="$cipher $protocols $pubkey $sigalg $trusted $tickethint $ocspstaple $pfs $current_curves $curves_ordering"
         verbose "handshake failed, server returned ciphersuite '$result'"
         return 1
@@ -556,9 +556,9 @@ test_cipher_on_target() {
         # if pfs uses ECDH, test supported curves
         if [[ $pfs =~ ECDH ]]; then
             has_curves="True"
-            if [ $TEST_CURVES == "True" ]; then
+            if [[ $TEST_CURVES == "True" ]]; then
                 test_curves
-                if [ "$ecc_ciphers" != "" ]; then
+                if [[ "$ecc_ciphers" != "" ]]; then
                     ecc_ciphers+=":"
                 fi
                 ecc_ciphers+="$cipher"
@@ -582,7 +582,7 @@ bench_cipher() {
     for i in $(seq 1 $BENCHMARKITER); do
         debug Connection $i
         (echo "Q" | $sslcommand 2>/dev/null 1>/dev/null)
-        if [ $? -gt 0 ]; then
+        if [[ $? -gt 0 ]]; then
             break
         fi
     done
@@ -596,13 +596,13 @@ bench_cipher() {
 # Connect to the target and retrieve the chosen cipher
 # recursively until the connection fails
 get_cipher_pref() {
-    [ "$OUTPUTFORMAT" == "terminal" ] && [ $DEBUG -lt 1 ] && echo -n '.'
+    [[ "$OUTPUTFORMAT" == "terminal" ]] && [[ $DEBUG -lt 1 ]] && echo -n '.'
     local ciphersuite="$1"
 
     local sslcommand="$TIMEOUTBIN $TIMEOUT $OPENSSLBIN s_client"
-    if [ -n "$CAPATH" ]; then
+    if [[ -n "$CAPATH" ]]; then
         sslcommand+=" -CApath $CAPATH -showcerts"
-    elif [ -e $CACERTS ]; then
+    elif [[ -e $CACERTS ]]; then
         sslcommand+=" -CAfile $CACERTS"
     fi
     sslcommand+=" -status $SCLIENTARGS -connect $TARGET -cipher $ciphersuite"
@@ -611,7 +611,7 @@ get_cipher_pref() {
     test_cipher_on_target "$sslcommand"
     local success=$?
     # If the connection succeeded with the current cipher, benchmark and store
-    if [ $success -eq 0 ]; then
+    if [[ $success -eq 0 ]]; then
         cipherspref=("${cipherspref[@]}" "$result")
         ciphercertificates=("${ciphercertificates[@]}" "$certificates")
         pciph=($result)
@@ -634,14 +634,14 @@ display_results_in_terminal() {
     for cipher in "${cipherspref[@]}"; do
         # get first in array
         pciph=($cipher)
-        if [ $DOBENCHMARK -eq 1 ]; then
+        if [[ $DOBENCHMARK -eq 1 ]]; then
             bench_cipher "$pciph"
             r="$ctr $cipher $cipherbenchms"
         else
             r="$ctr $cipher"
         fi
         local cipher_data=($cipher)
-        if [ $ctr -eq 1 ]; then
+        if [[ $ctr -eq 1 ]]; then
             pubkey="${cipher_data[2]}"
             sigalg="${cipher_data[3]}"
             trusted="${cipher_data[4]}"
@@ -651,19 +651,19 @@ display_results_in_terminal() {
                 curvesordering="${cipher_data[9]}"
             fi
         else
-            if [ "$pubkey" != "${cipher_data[2]}" ]; then
+            if [[ "$pubkey" != "${cipher_data[2]}" ]]; then
                 different=True
             fi
-            if [ "$sigalg" != "${cipher_data[3]}" ]; then
+            if [[ "$sigalg" != "${cipher_data[3]}" ]]; then
                 different=True
             fi
-            if [ "$trusted" != "${cipher_data[4]}" ]; then
+            if [[ "$trusted" != "${cipher_data[4]}" ]]; then
                 different=True
             fi
-            if [ "$tickethint" != "${cipher_data[5]}" ]; then
+            if [[ "$tickethint" != "${cipher_data[5]}" ]]; then
                 different=True
             fi
-            if [ "$ocspstaple" != "${cipher_data[6]}" ]; then
+            if [[ "$ocspstaple" != "${cipher_data[6]}" ]]; then
                 different=True
             fi
             if [[ "$curvesordering" == "" && "${cipher_data[9]}" != "" ]]; then
@@ -678,26 +678,26 @@ display_results_in_terminal() {
     done
 
     header="prio ciphersuite protocols"
-    if [ $different == "True" ]; then
+    if [[ $different == "True" ]]; then
         header+=" pubkey_size signature_algoritm trusted ticket_hint ocsp_staple"
     fi
     header+=" pfs"
-    if [ $has_curves == "True" ]; then
+    if [[ $has_curves == "True" ]]; then
         header+=" curves"
         if [[ $TEST_CURVES == "True" && $different == "True" ]]; then
             header+=" curves_ordering"
         fi
     fi
-    if [ $DOBENCHMARK -eq 1 ]; then
+    if [[ $DOBENCHMARK -eq 1 ]]; then
         header+=" avg_handshake_microsec"
     fi
     ctr=0
     for result in "${results[@]}"; do
-        if [ $ctr -eq 0 ]; then
+        if [[ $ctr -eq 0 ]]; then
             echo $header
             ctr=$((ctr+1))
         fi
-        if [ $different == "True" ]; then
+        if [[ $different == "True" ]]; then
             echo $result|grep -v '(NONE)'
         else
             # prints priority, ciphersuite, protocols and pfs
@@ -705,8 +705,8 @@ display_results_in_terminal() {
         fi
     done|column -t
     echo
-    if [ $different != "True" ]; then
-        if [ "$trusted" == "True" ]; then
+    if [[ $different != "True" ]]; then
+        if [[ "$trusted" == "True" ]]; then
             echo "Certificate: trusted, $pubkey bit, $sigalg signature"
         else
             echo "Certificate: UNTRUSTED, $pubkey bit, $sigalg signature"
@@ -723,7 +723,7 @@ display_results_in_terminal() {
     else
         echo "Cipher ordering: client"
     fi
-    if [ $TEST_CURVES == "True" ]; then
+    if [[ $TEST_CURVES == "True" ]]; then
         echo "Curves ordering: $curvesordering"
         echo "Curves fallback: $fallback_supported"
     fi
@@ -746,7 +746,7 @@ display_results_in_json() {
     echo -n "{\"target\":\"$TARGET\",\"utctimestamp\":\"$(date -u '+%FT%T.0Z')\",\"serverside\":\"${serverside}\",\"ciphersuite\": ["
     for cipher in "${cipherspref[@]}"; do
         local cipher_arr=($cipher)
-        [ $ctr -gt 0 ] && echo -n ','
+        [[ $ctr -gt 0 ]] && echo -n ','
         echo -n "{\"cipher\":\"${cipher_arr[0]}\","
         echo -n "\"protocols\":[\"${cipher_arr[1]//,/\",\"}\"],"
         echo -n "\"pubkey\":[\"${cipher_arr[2]//,/\",\"}\"],"
@@ -758,12 +758,12 @@ display_results_in_json() {
         echo -n "\"ticket_hint\":\"${cipher_arr[5]}\","
         echo -n "\"ocsp_stapling\":\"${cipher_arr[6]}\","
         pfs="${cipher_arr[7]}"
-        [ "$pfs" == "" ] && pfs="None"
+        [[ "$pfs" == "" ]] && pfs="None"
         echo -n "\"pfs\":\"$pfs\""
         if [[ "${cipher_arr[0]}" =~ ECDH ]]; then
             echo -n ","
             echo -n "\"curves\":[\"${cipher_arr[8]//,/\",\"}\"]"
-            if [ $TEST_CURVES == "True" ]; then
+            if [[ $TEST_CURVES == "True" ]]; then
                 echo -n ","
                 echo -n "\"curves_ordering\":\"${cipher_arr[9]}\""
             fi
@@ -772,14 +772,14 @@ display_results_in_json() {
         ctr=$((ctr+1))
     done
     echo -n ']'
-    if [ $TEST_CURVES == "True" ]; then
+    if [[ $TEST_CURVES == "True" ]]; then
         echo -n ",\"curves_fallback\":\"$fallback_supported\""
     fi
     echo -n ',"configs":{'
     ctr=0
     for test_name in "${!tls_tolerance[@]}"; do
         local result=(${tls_tolerance[$test_name]})
-        [ $ctr -gt 0 ] && echo -n ","
+        [[ $ctr -gt 0 ]] && echo -n ","
         echo -n "\"$test_name\":{"
         if [[ ${result[0]} == "False" ]]; then
             echo -n "\"tolerant\":\"False\""
@@ -826,15 +826,15 @@ test_serverside_ordering() {
     fi
 
     local sslcommand="$TIMEOUTBIN $TIMEOUT $OPENSSLBIN s_client"
-    if [ -n "$CAPATH" ]; then
+    if [[ -n "$CAPATH" ]]; then
         sslcommand+=" -CApath $CAPATH -showcerts"
-    elif [ -e "$CACERTS" ]; then
+    elif [[ -e "$CACERTS" ]]; then
         sslcommand+=" -CAfile $CACERTS"
     fi
     sslcommand+=" -status $SCLIENTARGS -connect $TARGET -cipher $ciphersuite"
 
     test_cipher_on_target "$sslcommand"
-    if [ $? -ne 0 ]; then
+    if [[ $? -ne 0 ]]; then
         serverside="True"
     else
         local selected=($result)
@@ -866,9 +866,9 @@ test_curves() {
     # prepare the ssl command we'll be using
     local sslcommand=""
     sslcommand="$TIMEOUTBIN $TIMEOUT $OPENSSLBIN s_client"
-    if [ -n "$CAPATH" ]; then
+    if [[ -n "$CAPATH" ]]; then
         sslcommand+=" -CApath $CAPATH -showcerts"
-    elif [ -e "$CACERTS" ]; then
+    elif [[ -e "$CACERTS" ]]; then
         sslcommand+=" -CAfile $CACERTS"
     fi
     sslcommand+=" -status $SCLIENTARGS -connect $TARGET -cipher $current_cipher"
@@ -900,7 +900,7 @@ test_curves() {
             local ephem_data=(${current_pfs//,/ })
             local cname=""
             if [[ ${ephem_data[0]} =~ ECDH ]]; then
-                if [ "$current_curves" != "" ]; then
+                if [[ "$current_curves" != "" ]]; then
                     current_curves+=","
                 fi
                 cname="$(get_curve_name ${ephem_data[1]})"
@@ -908,14 +908,14 @@ test_curves() {
                 current_curves+="$cname"
             fi
             for id in "${!curves[@]}"; do
-                if [ "$cname" == ${curves[$id]} ]; then
+                if [[ "$cname" == ${curves[$id]} ]]; then
                     # we know it's supported, remove it from set of offered ones
                     unset curves[$id]
                     break
                 fi
             done
         fi
-        [ "$OUTPUTFORMAT" == "terminal" ] && [ $DEBUG -lt 1 ] && echo -n '.'
+        [[ "$OUTPUTFORMAT" == "terminal" ]] && [[ $DEBUG -lt 1 ]] && echo -n '.'
     done
 
     # don't penalize servers that will negotiate all curves we know of...
@@ -932,7 +932,7 @@ test_curves() {
 
     # server supports just one or none, so it effectively uses server side
     # ordering (as it dictates what curves client must support)
-    if [ ${#tmp_curves[@]} -lt 2 ]; then
+    if [[ ${#tmp_curves[@]} -lt 2 ]]; then
         curves_ordering="server"
     else
         # server supports at least 2 curves, rotate their order, see if
@@ -961,7 +961,7 @@ test_curves() {
                 verbose "Server did select ${ephem_data[1]} curve"
                 curves_ordering="inconclusive-${ephem_data[1]}"
                 local cname="$(get_curve_name ${ephem_data[1]})"
-                if [ "$cname" == "$most_wanted" ]; then
+                if [[ "$cname" == "$most_wanted" ]]; then
                     curves_ordering="client"
                 else
                     curves_ordering="server"
@@ -981,7 +981,7 @@ test_curves_fallback() {
     # client doesn't advertise support for curves the server needs
     fallback_supported="unknown"
 
-    if [ "$ecc_ciphers" == "" ]; then
+    if [[ "$ecc_ciphers" == "" ]]; then
         verbose "No ECC cipher found, can't test curve fallback"
         return
     fi
@@ -989,9 +989,9 @@ test_curves_fallback() {
     # prepare the ssl command we'll be using
     local sslcommand=""
     sslcommand="$TIMEOUTBIN $TIMEOUT $OPENSSLBIN s_client"
-    if [ -n "$CAPATH" ]; then
+    if [[ -n "$CAPATH" ]]; then
         sslcommand+=" -CApath $CAPATH -showcerts"
-    elif [ -e "$CACERTS" ]; then
+    elif [[ -e "$CACERTS" ]]; then
         sslcommand+=" -CAfile $CACERTS"
     fi
     sslcommand+=" -status $SCLIENTARGS -connect $TARGET -cipher $ecc_ciphers"
@@ -1030,7 +1030,7 @@ test_curves_fallback() {
                 local cname="$(get_curve_name ${ephem_data[1]})"
                 verbose "Server selected curve $cname"
                 for id in "${!curves[@]}"; do
-                    if [ "${curves[id]}" == "$cname" ]; then
+                    if [[ "${curves[id]}" == "$cname" ]]; then
                         unset curves[$id]
                         break
                     fi
@@ -1083,9 +1083,9 @@ test_tls_tolerance() {
         # cipher string and no options are specified)
         #
         local sslcommand="$TIMEOUTBIN $TIMEOUT $OPENSSLBIN s_client"
-        if [ -n "$CAPATH" ]; then
+        if [[ -n "$CAPATH" ]]; then
             sslcommand+=" -CApath $CAPATH -showcerts"
-        elif [ -e "$CACERTS" ]; then
+        elif [[ -e "$CACERTS" ]]; then
             sslcommand+=" -CAfile $CACERTS"
         fi
         sslcommand+=" -connect $TARGET -cipher $CIPHERSUITE"
@@ -1111,9 +1111,9 @@ test_tls_tolerance() {
         IFS="$OLDIFS"
 
         local sslcommand="$TIMEOUTBIN $TIMEOUT $OPENSSLBIN s_client"
-        if [ -n "$CAPATH" ]; then
+        if [[ -n "$CAPATH" ]]; then
             sslcommand+=" -CApath $CAPATH -showcerts"
-        elif [ -e "$CACERTS" ]; then
+        elif [[ -e "$CACERTS" ]]; then
             sslcommand+=" -CAfile $CACERTS"
         fi
         sslcommand+=" -connect $TARGET -cipher $ciphers"
@@ -1185,9 +1185,9 @@ test_tls_tolerance() {
         IFS="$OLDIFS"
 
         local sslcommand="$TIMEOUTBIN $TIMEOUT $OPENSSLBIN s_client"
-        if [ -n "$CAPATH" ]; then
+        if [[ -n "$CAPATH" ]]; then
             sslcommand+=" -CApath $CAPATH -showcerts"
-        elif [ -e "$CACERTS" ]; then
+        elif [[ -e "$CACERTS" ]]; then
             sslcommand+=" -CAfile $CACERTS"
         fi
         sslcommand+=" $SCLIENTARGS -connect $TARGET -cipher $ciphers:!SSLv2"
@@ -1269,7 +1269,7 @@ test_tls_tolerance() {
 }
 
 # If no options are given, give usage information and exit (with error code)
-if [ $# -eq 0 ]; then
+if [[ $# -eq 0 ]]; then
    usage;
    exit 1
 fi
@@ -1353,7 +1353,7 @@ HOST=$(sed -e 's/:.*//'<<<"${TEMPTARGET}")
 PORT=$(sed -e 's/.*://'<<<"${TEMPTARGET}")
 
 # Default to https if no port given
-if [ "$HOST" = "$PORT" ]; then
+if [[ "$HOST" = "$PORT" ]]; then
     PORT=443
 fi
 
@@ -1364,22 +1364,22 @@ TARGET=$HOST:$PORT
 debug "target: $TARGET"
 
 # test our openssl is usable
-if [ ! -x $OPENSSLBIN ]; then
+if [[ ! -x $OPENSSLBIN ]]; then
     OPENSSLBIN=$(which openssl)
-    if [ "$OUTPUTFORMAT" == "terminal" ]; then
+    if [[ "$OUTPUTFORMAT" == "terminal" ]]; then
         echo "custom openssl not executable, falling back to system one from $OPENSSLBIN"
     fi
 fi
 
-if [ $TEST_CURVES == "True" ]; then
-    if [ ! -z "$($OPENSSLBIN s_client -curves 2>&1|head -1|grep 'unknown option')" ]; then
+if [[ $TEST_CURVES == "True" ]]; then
+    if [[ ! -z "$($OPENSSLBIN s_client -curves 2>&1|head -1|grep 'unknown option')" ]]; then
         echo "curves testing not available with your version of openssl, disabling it"
         TEST_CURVES="False"
     fi
 fi
 
-if [ $VERBOSE != 0 ] ; then
-    [ -n "$CACERTS" ] && echo "Using trust anchors from $CACERTS"
+if [[ $VERBOSE != 0 ]] ; then
+    [[ -n "$CACERTS" ]] && echo "Using trust anchors from $CACERTS"
     echo "Loading $($OPENSSLBIN ciphers -v $CIPHERSUITE 2>/dev/null|grep Kx|wc -l) ciphersuites from $(echo -n $($OPENSSLBIN version 2>/dev/null))"
          $OPENSSLBIN ciphers ALL 2>/dev/null
 fi
@@ -1419,7 +1419,7 @@ if [[ $TEST_CURVES == "True" ]]; then
     test_curves_fallback
 fi
 
-if [ "$OUTPUTFORMAT" == "json" ]; then
+if [[ "$OUTPUTFORMAT" == "json" ]]; then
     display_results_in_json
 else
     echo
@@ -1427,13 +1427,13 @@ else
 fi
 
 # If asked, test every single cipher individually
-if [ $ALLCIPHERS -gt 0 ]; then
+if [[ $ALLCIPHERS -gt 0 ]]; then
     echo; echo "All accepted ciphersuites"
     for c in $($OPENSSLBIN ciphers -v ALL:COMPLEMENTOFALL 2>/dev/null |awk '{print $1}'|sort|uniq); do
         r="fail"
         osslcommand="$TIMEOUTBIN $TIMEOUT $OPENSSLBIN s_client $SCLIENTARGS -connect $TARGET -cipher $c"
         test_cipher_on_target "$osslcommand"
-        if [ $? -eq 0 ]; then
+        if [[ $? -eq 0 ]]; then
             r="pass"
         fi
         echo "$c $r"|awk '{printf "%-35s %s\n",$1,$2}'

From 9e563782e220056c2a878044860187bff0796a22 Mon Sep 17 00:00:00 2001
From: Richard Soderberg <rsoderberg@gmail.com>
Date: Thu, 3 Sep 2015 06:00:23 -0700
Subject: [PATCH 02/14] fix syntax error in busybox check - $(( is not the same
 as $( (, and a subshell is unnecessary here in any case

---
 cipherscan | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/cipherscan b/cipherscan
index 7e23844..d607975 100755
--- a/cipherscan
+++ b/cipherscan
@@ -37,7 +37,7 @@ if [[ "$TIMEOUTBIN" == "" ]]; then
 fi
 
 # Check for busybox, which has different arguments
-TIMEOUTOUTPUT=$(($TIMEOUTBIN --help) 2>&1)
+TIMEOUTOUTPUT="$($TIMEOUTBIN --help 2>&1)"
 if [[ "$TIMEOUTOUTPUT" =~ BusyBox ]]; then
     TIMEOUTBIN="$TIMEOUTBIN -t"
 fi

From 10057f93dccc0a3d2a8f8e308e78e15a5c0a578d Mon Sep 17 00:00:00 2001
From: Richard Soderberg <rsoderberg@gmail.com>
Date: Wed, 2 Sep 2015 21:47:13 -0700
Subject: [PATCH 03/14] revise whitespace layout of cipher, curve arrays to
 improve future diffs

---
 cipherscan | 20 +++++++++++++-------
 1 file changed, 13 insertions(+), 7 deletions(-)

diff --git a/cipherscan b/cipherscan
index d607975..970ae5a 100755
--- a/cipherscan
+++ b/cipherscan
@@ -65,7 +65,8 @@ fi
 CIPHERSUITE="ALL:COMPLEMENTOFALL:+aRSA"
 # some servers are intolerant to large client hello, try a shorter list of
 # ciphers with them
-SHORTCIPHERSUITE=('ECDHE-ECDSA-AES128-GCM-SHA256'
+SHORTCIPHERSUITE=(
+        'ECDHE-ECDSA-AES128-GCM-SHA256'
         'ECDHE-RSA-AES128-GCM-SHA256'
         'ECDHE-RSA-AES256-GCM-SHA384'
         'ECDHE-ECDSA-AES256-SHA'
@@ -88,7 +89,8 @@ SHORTCIPHERSUITE=('ECDHE-ECDSA-AES128-GCM-SHA256'
         'CAMELLIA256-SHA'
         'DES-CBC3-SHA'
         'RC4-SHA'
-        'RC4-MD5')
+        'RC4-MD5'
+)
 # as some servers are intolerant to large client hello's (or ones that have
 # RC4 ciphers below position 64), use the following for cipher testing in case
 # of problems
@@ -126,7 +128,7 @@ FALLBACKCIPHERSUITE=(
         'EXP-DES-CBC-SHA'
         'EXP-RC2-CBC-MD5'
         'EXP-RC4-MD5'
-        )
+)
 DEBUG=0
 VERBOSE=0
 DELAY=0
@@ -205,7 +207,8 @@ debug(){
 }
 
 # obtain an array of curves supported by openssl
-CURVES=(sect163k1 # K-163
+CURVES=(
+    sect163k1 # K-163
     sect163r1
     sect163r2 # B-163
     sect193r1
@@ -232,11 +235,13 @@ CURVES=(sect163k1 # K-163
     secp521r1 # P-521
     brainpoolP256r1
     brainpoolP384r1
-    brainpoolP512r1)
+    brainpoolP512r1
+)
 
 # many curves have alternative names, this array provides a mapping to find the IANA
 # name of a curve using its alias
-CURVES_MAP=("sect163k1 K-163"
+CURVES_MAP=(
+      "sect163k1 K-163"
       "sect163r2 B-163"
       "sect233k1 K-233"
       "sect233r1 B-233"
@@ -250,7 +255,8 @@ CURVES_MAP=("sect163k1 K-163"
       "secp224r1 P-224"
       "prime256v1 P-256 secp256r1"
       "secp384r1 P-384"
-      "secp521r1 P-521")
+      "secp521r1 P-521"
+)
 
 get_curve_name() {
     local identifier=$1

From 81481cd016d7c1ad8f077d3565f3993f806dd37d Mon Sep 17 00:00:00 2001
From: Richard Soderberg <rsoderberg@gmail.com>
Date: Wed, 2 Sep 2015 21:51:15 -0700
Subject: [PATCH 04/14] requote, reindent ciphers and curves to the same format

---
 cipherscan | 200 ++++++++++++++++++++++++++---------------------------
 1 file changed, 100 insertions(+), 100 deletions(-)

diff --git a/cipherscan b/cipherscan
index 970ae5a..e1dba57 100755
--- a/cipherscan
+++ b/cipherscan
@@ -66,68 +66,68 @@ CIPHERSUITE="ALL:COMPLEMENTOFALL:+aRSA"
 # some servers are intolerant to large client hello, try a shorter list of
 # ciphers with them
 SHORTCIPHERSUITE=(
-        'ECDHE-ECDSA-AES128-GCM-SHA256'
-        'ECDHE-RSA-AES128-GCM-SHA256'
-        'ECDHE-RSA-AES256-GCM-SHA384'
-        'ECDHE-ECDSA-AES256-SHA'
-        'ECDHE-ECDSA-AES128-SHA'
-        'ECDHE-RSA-AES128-SHA'
-        'ECDHE-RSA-AES256-SHA'
-        'ECDHE-RSA-DES-CBC3-SHA'
-        'ECDHE-ECDSA-RC4-SHA'
-        'ECDHE-RSA-RC4-SHA'
-        'DHE-RSA-AES128-SHA'
-        'DHE-DSS-AES128-SHA'
-        'DHE-RSA-CAMELLIA128-SHA'
-        'DHE-RSA-AES256-SHA'
-        'DHE-DSS-AES256-SHA'
-        'DHE-RSA-CAMELLIA256-SHA'
-        'EDH-RSA-DES-CBC3-SHA'
-        'AES128-SHA'
-        'CAMELLIA128-SHA'
-        'AES256-SHA'
-        'CAMELLIA256-SHA'
-        'DES-CBC3-SHA'
-        'RC4-SHA'
-        'RC4-MD5'
+    'ECDHE-ECDSA-AES128-GCM-SHA256'
+    'ECDHE-RSA-AES128-GCM-SHA256'
+    'ECDHE-RSA-AES256-GCM-SHA384'
+    'ECDHE-ECDSA-AES256-SHA'
+    'ECDHE-ECDSA-AES128-SHA'
+    'ECDHE-RSA-AES128-SHA'
+    'ECDHE-RSA-AES256-SHA'
+    'ECDHE-RSA-DES-CBC3-SHA'
+    'ECDHE-ECDSA-RC4-SHA'
+    'ECDHE-RSA-RC4-SHA'
+    'DHE-RSA-AES128-SHA'
+    'DHE-DSS-AES128-SHA'
+    'DHE-RSA-CAMELLIA128-SHA'
+    'DHE-RSA-AES256-SHA'
+    'DHE-DSS-AES256-SHA'
+    'DHE-RSA-CAMELLIA256-SHA'
+    'EDH-RSA-DES-CBC3-SHA'
+    'AES128-SHA'
+    'CAMELLIA128-SHA'
+    'AES256-SHA'
+    'CAMELLIA256-SHA'
+    'DES-CBC3-SHA'
+    'RC4-SHA'
+    'RC4-MD5'
 )
 # as some servers are intolerant to large client hello's (or ones that have
 # RC4 ciphers below position 64), use the following for cipher testing in case
 # of problems
 FALLBACKCIPHERSUITE=(
-        'ECDHE-RSA-AES128-GCM-SHA256'
-        'ECDHE-RSA-AES128-SHA256'
-        'ECDHE-RSA-AES128-SHA'
-        'ECDHE-RSA-DES-CBC3-SHA'
-        'ECDHE-RSA-RC4-SHA'
-        'DHE-RSA-AES128-SHA'
-        'DHE-DSS-AES128-SHA'
-        'DHE-RSA-CAMELLIA128-SHA'
-        'DHE-RSA-AES256-SHA'
-        'DHE-DSS-AES256-SHA'
-        'DHE-RSA-CAMELLIA256-SHA'
-        'EDH-RSA-DES-CBC3-SHA'
-        'AES128-SHA'
-        'CAMELLIA128-SHA'
-        'AES256-SHA'
-        'CAMELLIA256-SHA'
-        'DES-CBC3-SHA'
-        'RC4-SHA'
-        'RC4-MD5'
-        'SEED-SHA'
-        'IDEA-CBC-SHA'
-        'IDEA-CBC-MD5'
-        'RC2-CBC-MD5'
-        'DES-CBC3-MD5'
-        'EXP1024-DHE-DSS-DES-CBC-SHA'
-        'EDH-RSA-DES-CBC-SHA'
-        'EXP1024-DES-CBC-SHA'
-        'DES-CBC-MD5'
-        'EXP1024-RC4-SHA'
-        'EXP-EDH-RSA-DES-CBC-SHA'
-        'EXP-DES-CBC-SHA'
-        'EXP-RC2-CBC-MD5'
-        'EXP-RC4-MD5'
+    'ECDHE-RSA-AES128-GCM-SHA256'
+    'ECDHE-RSA-AES128-SHA256'
+    'ECDHE-RSA-AES128-SHA'
+    'ECDHE-RSA-DES-CBC3-SHA'
+    'ECDHE-RSA-RC4-SHA'
+    'DHE-RSA-AES128-SHA'
+    'DHE-DSS-AES128-SHA'
+    'DHE-RSA-CAMELLIA128-SHA'
+    'DHE-RSA-AES256-SHA'
+    'DHE-DSS-AES256-SHA'
+    'DHE-RSA-CAMELLIA256-SHA'
+    'EDH-RSA-DES-CBC3-SHA'
+    'AES128-SHA'
+    'CAMELLIA128-SHA'
+    'AES256-SHA'
+    'CAMELLIA256-SHA'
+    'DES-CBC3-SHA'
+    'RC4-SHA'
+    'RC4-MD5'
+    'SEED-SHA'
+    'IDEA-CBC-SHA'
+    'IDEA-CBC-MD5'
+    'RC2-CBC-MD5'
+    'DES-CBC3-MD5'
+    'EXP1024-DHE-DSS-DES-CBC-SHA'
+    'EDH-RSA-DES-CBC-SHA'
+    'EXP1024-DES-CBC-SHA'
+    'DES-CBC-MD5'
+    'EXP1024-RC4-SHA'
+    'EXP-EDH-RSA-DES-CBC-SHA'
+    'EXP-DES-CBC-SHA'
+    'EXP-RC2-CBC-MD5'
+    'EXP-RC4-MD5'
 )
 DEBUG=0
 VERBOSE=0
@@ -208,54 +208,54 @@ debug(){
 
 # obtain an array of curves supported by openssl
 CURVES=(
-    sect163k1 # K-163
-    sect163r1
-    sect163r2 # B-163
-    sect193r1
-    sect193r2
-    sect233k1 # K-233
-    sect233r1 # B-233
-    sect239k1
-    sect283k1 # K-283
-    sect283r1 # B-283
-    sect409k1 # K-409
-    sect409r1 # B-409
-    sect571k1 # K-571
-    sect571r1 # B-571
-    secp160k1
-    secp160r1
-    secp160r2
-    secp192k1
-    prime192v1 # P-192 secp192r1
-    secp224k1
-    secp224r1 # P-224
-    secp256k1
-    prime256v1 # P-256 secp256r1
-    secp384r1 # P-384
-    secp521r1 # P-521
-    brainpoolP256r1
-    brainpoolP384r1
-    brainpoolP512r1
+    'sect163k1' # K-163
+    'sect163r1'
+    'sect163r2' # B-163
+    'sect193r1'
+    'sect193r2'
+    'sect233k1' # K-233
+    'sect233r1' # B-233
+    'sect239k1'
+    'sect283k1' # K-283
+    'sect283r1' # B-283
+    'sect409k1' # K-409
+    'sect409r1' # B-409
+    'sect571k1' # K-571
+    'sect571r1' # B-571
+    'secp160k1'
+    'secp160r1'
+    'secp160r2'
+    'secp192k1'
+    'prime192v1' # P-192 secp192r1
+    'secp224k1'
+    'secp224r1' # P-224
+    'secp256k1'
+    'prime256v1' # P-256 secp256r1
+    'secp384r1' # P-384
+    'secp521r1' # P-521
+    'brainpoolP256r1'
+    'brainpoolP384r1'
+    'brainpoolP512r1'
 )
 
 # many curves have alternative names, this array provides a mapping to find the IANA
 # name of a curve using its alias
 CURVES_MAP=(
-      "sect163k1 K-163"
-      "sect163r2 B-163"
-      "sect233k1 K-233"
-      "sect233r1 B-233"
-      "sect283k1 K-283"
-      "sect283r1 B-283"
-      "sect409k1 K-409"
-      "sect409r1 B-409"
-      "sect571k1 K-571"
-      "sect571r1 B-571"
-      "prime192v1 P-192 secp192r1"
-      "secp224r1 P-224"
-      "prime256v1 P-256 secp256r1"
-      "secp384r1 P-384"
-      "secp521r1 P-521"
+    'sect163k1 K-163'
+    'sect163r2 B-163'
+    'sect233k1 K-233'
+    'sect233r1 B-233'
+    'sect283k1 K-283'
+    'sect283r1 B-283'
+    'sect409k1 K-409'
+    'sect409r1 B-409'
+    'sect571k1 K-571'
+    'sect571r1 B-571'
+    'prime192v1 P-192 secp192r1'
+    'secp224r1 P-224'
+    'prime256v1 P-256 secp256r1'
+    'secp384r1 P-384'
+    'secp521r1 P-521'
 )
 
 get_curve_name() {

From 1c15af1ce32aaad7fb4d7a5cb842f421483f72cc Mon Sep 17 00:00:00 2001
From: Richard Soderberg <rsoderberg@gmail.com>
Date: Wed, 2 Sep 2015 21:57:24 -0700
Subject: [PATCH 05/14] verify the results of pushd rather than trusting it

---
 cipherscan | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/cipherscan b/cipherscan
index e1dba57..64f6a85 100755
--- a/cipherscan
+++ b/cipherscan
@@ -281,8 +281,12 @@ c_hash() {
         fi
         if [[ ! -e $1/${h}.${num} ]]; then
             # file doesn't exist, create a link
-            pushd "$1" > /dev/null
-            ln -s "$2" "${h}.${num}"
+            if pushd "$1" > /dev/null; then
+                ln -s "$2" "${h}.${num}"
+            else
+                echo "'pushd $1' failed unexpectedly, refusing to proceed" 1>&2
+                exit 1
+            fi
             popd > /dev/null
             break
         fi

From bbb349662794a4482380849dd07a20c0585d2f66 Mon Sep 17 00:00:00 2001
From: Richard Soderberg <rsoderberg@gmail.com>
Date: Wed, 2 Sep 2015 21:58:31 -0700
Subject: [PATCH 06/14] trim dead trailing ;

---
 cipherscan | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/cipherscan b/cipherscan
index 64f6a85..cf115b7 100755
--- a/cipherscan
+++ b/cipherscan
@@ -1280,7 +1280,7 @@ test_tls_tolerance() {
 
 # If no options are given, give usage information and exit (with error code)
 if [[ $# -eq 0 ]]; then
-   usage;
+   usage
    exit 1
 fi
 
@@ -1398,7 +1398,7 @@ SCLIENTARGS=$(sed -e s,${TEMPTARGET},,<<<"${@}")
 debug "sclientargs: $SCLIENTARGS"
 
 
-cipherspref=();
+cipherspref=()
 ciphercertificates=()
 results=()
 

From 3664b1a1991103337f4eb9b253f9955f5afcfbbc Mon Sep 17 00:00:00 2001
From: Richard Soderberg <rsoderberg@gmail.com>
Date: Thu, 3 Sep 2015 06:11:40 -0700
Subject: [PATCH 07/14] fixes for "SC2145: Argument mixes string and array. Use
 * or separate argument."

In cipherscan line 941:
    verbose "Server supported curves: ${tmp_curves[@]}"
                                      ^-- SC2145: Argument mixes string and array. Use * or separate argument.

In cipherscan line 968:
            verbose "ephem_data: ${ephem_data[@]}"
                                 ^-- SC2145: Argument mixes string and array. Use * or separate argument.
---
 cipherscan | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/cipherscan b/cipherscan
index cf115b7..1ecb3ee 100755
--- a/cipherscan
+++ b/cipherscan
@@ -938,7 +938,7 @@ test_curves() {
     #
 
     local tmp_curves=(${current_curves//,/ })
-    verbose "Server supported curves: ${tmp_curves[@]}"
+    verbose "Server supported curves: ${tmp_curves[*]}"
 
     # server supports just one or none, so it effectively uses server side
     # ordering (as it dictates what curves client must support)
@@ -965,7 +965,7 @@ test_curves() {
         else
             local ephem_data=(${current_pfs//,/ })
             verbose "Server selected $current_cipher with $current_pfs"
-            verbose "ephem_data: ${ephem_data[@]}"
+            verbose "ephem_data: ${ephem_data[*]}"
 
             if [[ ${ephem_data[0]} =~ ECDH ]]; then
                 verbose "Server did select ${ephem_data[1]} curve"

From 4405d3fdce3d70bd3f029482ed465edc5219ec17 Mon Sep 17 00:00:00 2001
From: Richard Soderberg <rsoderberg@gmail.com>
Date: Thu, 3 Sep 2015 06:17:15 -0700
Subject: [PATCH 08/14] remove unused variable "fallback_available"

---
 cipherscan | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/cipherscan b/cipherscan
index 1ecb3ee..a5109a1 100755
--- a/cipherscan
+++ b/cipherscan
@@ -857,9 +857,6 @@ test_serverside_ordering() {
 }
 
 test_curves() {
-    # "True" if server supports ciphers that don't use ECC at a lower priority
-    local fallback_available="False"
-
     # return variable: list of curves supported by server, in order
     current_curves=""
     # return variable: check if server uses server side or client side ordering
@@ -985,8 +982,6 @@ test_curves() {
 }
 
 test_curves_fallback() {
-    # "True" if server supports ciphers that don't use ECC at a lower priority
-    local fallback_available="False"
     # return variable: whatever a server will fall back to non ECC suite when
     # client doesn't advertise support for curves the server needs
     fallback_supported="unknown"

From 21871b5bd7293cb3aa81dafb8c876ee78e315725 Mon Sep 17 00:00:00 2001
From: Richard Soderberg <rsoderberg@gmail.com>
Date: Thu, 3 Sep 2015 06:25:15 -0700
Subject: [PATCH 09/14] fixes for "SC2046: Quote this to prevent word
 splitting." and "SC2086: Double quote to prevent globbing and word
 splitting."

In cipherscan line 13:
REALPATH=$(dirname $0)
                   ^-- SC2086: Double quote to prevent globbing and word splitting.

In cipherscan line 15:
readlink -f $0 &>/dev/null && REALPATH=$(dirname $(readlink -f $0))
            ^-- SC2086: Double quote to prevent globbing and word splitting.
                                                 ^-- SC2046: Quote this to prevent word splitting.
                                                               ^-- SC2086: Double quote to prevent globbing and word splitting.

In cipherscan line 46:
if [[ -e $(dirname $0)/openssl.cnf ]]; then
                   ^-- SC2086: Double quote to prevent globbing and word splitting.

In cipherscan line 47:
    export OPENSSL_CONF="$(dirname $0)/openssl.cnf"
           ^-- SC2155: Declare and assign separately to avoid masking return values.
                                   ^-- SC2086: Double quote to prevent globbing and word splitting.

In cipherscan line 60:
    CACERTS="$(dirname $0)/ca-bundle.crt"
                       ^-- SC2086: Double quote to prevent globbing and word splitting.
---
 cipherscan | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/cipherscan b/cipherscan
index a5109a1..8093918 100755
--- a/cipherscan
+++ b/cipherscan
@@ -10,9 +10,9 @@
 
 DOBENCHMARK=0
 BENCHMARKITER=30
-REALPATH=$(dirname $0)
+REALPATH=$(dirname "$0")
 # make sure this doesn't error out when readlink -f isn't available (OSX)
-readlink -f $0 &>/dev/null && REALPATH=$(dirname $(readlink -f $0))
+readlink -f "$0" &>/dev/null && REALPATH=$(dirname "$(readlink -f "$0")")
 OPENSSLBIN="${REALPATH}/openssl"
 if [[ "$(uname -s)" == "Darwin" ]]; then
     OPENSSLBIN="${REALPATH}/openssl-darwin64"
@@ -43,8 +43,8 @@ if [[ "$TIMEOUTOUTPUT" =~ BusyBox ]]; then
 fi
 
 # use custom config file to enable GOST ciphers
-if [[ -e $(dirname $0)/openssl.cnf ]]; then
-    export OPENSSL_CONF="$(dirname $0)/openssl.cnf"
+if [[ -e $(dirname "$0")/openssl.cnf ]]; then
+    export OPENSSL_CONF="$(dirname "$0")/openssl.cnf"
 fi
 
 # find a list of trusted CAs on the local system, or use the provided list
@@ -57,7 +57,7 @@ if [[ -z "$CACERTS" ]]; then
     done
 fi
 if [[ ! -e "$CACERTS" ]]; then
-    CACERTS="$(dirname $0)/ca-bundle.crt"
+    CACERTS="$(dirname "$0")/ca-bundle.crt"
 fi
 
 # RSA ciphers are put at the end to force Google servers to accept ECDSA ciphers

From f002b3573afcd25c0bc19b4b2c8d22fda87af517 Mon Sep 17 00:00:00 2001
From: Richard Soderberg <rsoderberg@gmail.com>
Date: Thu, 3 Sep 2015 06:36:32 -0700
Subject: [PATCH 10/14] fixes for "SC2004: $/${} is unnecessary on arithmetic
 variables."

In cipherscan line 451:
        for ((i=0; i<$certificate_count; i=i+1 )); do
                     ^-- SC2004: $/${} is unnecessary on arithmetic variables.

In cipherscan line 603:
    cipherbenchms="$((t/1000/$BENCHMARKITER))"
                             ^-- SC2004: $/${} is unnecessary on arithmetic variables.
---
 cipherscan | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/cipherscan b/cipherscan
index 8093918..db5c143 100755
--- a/cipherscan
+++ b/cipherscan
@@ -448,7 +448,7 @@ test_cipher_on_target() {
         local certificate_count=$certs_found
         debug "server presented $certificate_count certificates"
         local i
-        for ((i=0; i<$certificate_count; i=i+1 )); do
+        for ((i=0; i<certificate_count; i=i+1 )); do
 
             # extract i'th certificate
             local cert="${current_raw_certificates[$i]}"
@@ -600,7 +600,7 @@ bench_cipher() {
     local t="$(($(date +%s%N) - t))"
     verbose "Benchmarking done in $t nanoseconds"
     # Microseconds
-    cipherbenchms="$((t/1000/$BENCHMARKITER))"
+    cipherbenchms="$((t/1000/BENCHMARKITER))"
 }
 
 # Connect to the target and retrieve the chosen cipher

From 5ec3184a375b93c3e05fa1a60c01347709798089 Mon Sep 17 00:00:00 2001
From: Richard Soderberg <rsoderberg@gmail.com>
Date: Thu, 3 Sep 2015 06:40:48 -0700
Subject: [PATCH 11/14] call dirname $0 three fewer times by caching the
 unmodified value prior to readlink modifications

---
 cipherscan | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/cipherscan b/cipherscan
index db5c143..ff05c02 100755
--- a/cipherscan
+++ b/cipherscan
@@ -10,7 +10,8 @@
 
 DOBENCHMARK=0
 BENCHMARKITER=30
-REALPATH=$(dirname "$0")
+DIRNAMEPATH=$(dirname "$0")
+REALPATH="$DIRNAMEPATH"
 # make sure this doesn't error out when readlink -f isn't available (OSX)
 readlink -f "$0" &>/dev/null && REALPATH=$(dirname "$(readlink -f "$0")")
 OPENSSLBIN="${REALPATH}/openssl"
@@ -43,8 +44,8 @@ if [[ "$TIMEOUTOUTPUT" =~ BusyBox ]]; then
 fi
 
 # use custom config file to enable GOST ciphers
-if [[ -e $(dirname "$0")/openssl.cnf ]]; then
-    export OPENSSL_CONF="$(dirname "$0")/openssl.cnf"
+if [[ -e $DIRNAMEPATH/openssl.cnf ]]; then
+    export OPENSSL_CONF="$DIRNAMEPATH/openssl.cnf"
 fi
 
 # find a list of trusted CAs on the local system, or use the provided list
@@ -57,7 +58,7 @@ if [[ -z "$CACERTS" ]]; then
     done
 fi
 if [[ ! -e "$CACERTS" ]]; then
-    CACERTS="$(dirname "$0")/ca-bundle.crt"
+    CACERTS="$DIRNAMEPATH/ca-bundle.crt"
 fi
 
 # RSA ciphers are put at the end to force Google servers to accept ECDSA ciphers

From f0142c323aa93462a66d451e8d89193dec6df60b Mon Sep 17 00:00:00 2001
From: Richard Soderberg <rsoderberg@gmail.com>
Date: Thu, 3 Sep 2015 06:47:47 -0700
Subject: [PATCH 12/14] remove one unnecessary assignment when on Darwin.

---
 cipherscan | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/cipherscan b/cipherscan
index ff05c02..16d2818 100755
--- a/cipherscan
+++ b/cipherscan
@@ -14,9 +14,10 @@ DIRNAMEPATH=$(dirname "$0")
 REALPATH="$DIRNAMEPATH"
 # make sure this doesn't error out when readlink -f isn't available (OSX)
 readlink -f "$0" &>/dev/null && REALPATH=$(dirname "$(readlink -f "$0")")
-OPENSSLBIN="${REALPATH}/openssl"
 if [[ "$(uname -s)" == "Darwin" ]]; then
     OPENSSLBIN="${REALPATH}/openssl-darwin64"
+else
+    OPENSSLBIN="${REALPATH}/openssl"
 fi
 
 # cipherscan requires bash4, which doesn't come by default in OSX

From 9a0e055628f66dad6fe99916267c3006ed9ad464 Mon Sep 17 00:00:00 2001
From: Richard Soderberg <rsoderberg@gmail.com>
Date: Thu, 3 Sep 2015 06:58:05 -0700
Subject: [PATCH 13/14] remove crude_grep in favor of a simple =~ substring
 match.

The crude_grep function served only to perform a simple substring check
against the output of openssl -help. So, instead of running the command
each time, iterating its output line by line, and checking for the
substring within it, this simply caches the -help output at startup and
uses $help =~ substring to produce the same result in a single pass.
---
 cipherscan | 13 ++-----------
 1 file changed, 2 insertions(+), 11 deletions(-)

diff --git a/cipherscan b/cipherscan
index 16d2818..defbf60 100755
--- a/cipherscan
+++ b/cipherscan
@@ -19,6 +19,7 @@ if [[ "$(uname -s)" == "Darwin" ]]; then
 else
     OPENSSLBIN="${REALPATH}/openssl"
 fi
+OPENSSLBINHELP="$($OPENSSLBIN s_client -help 2>&1)"
 
 # cipherscan requires bash4, which doesn't come by default in OSX
 if [[ ${BASH_VERSINFO[0]} -lt 4 ]]; then
@@ -295,18 +296,8 @@ c_hash() {
     done
 }
 
-crude_grep() {
-    while read line; do
-        if [[ $line =~ $1 ]]; then
-            return 0
-        fi
-    done
-    return 1
-}
-
 check_option_support() {
-    $OPENSSLBIN s_client -help 2>&1 | crude_grep "$1"
-    return $?
+    [[ $OPENSSLBINHELP =~ "$1" ]]
 }
 
 parse_openssl_output() {

From 22adaf188a51d99fcaaf77b0e07424ef99e8eb02 Mon Sep 17 00:00:00 2001
From: Richard Soderberg <rsoderberg@gmail.com>
Date: Thu, 3 Sep 2015 07:02:38 -0700
Subject: [PATCH 14/14] verify that the openssl binary is emitting a valid
 s_client -help.

This catches instances where the wrong openssl binary is selected (for
instance, if uname -s is neither Darwin nor Linux) and serves as a
simple up-front test to make sure that openssl is working before we
proceed further into the script.
---
 cipherscan | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/cipherscan b/cipherscan
index defbf60..21d52c6 100755
--- a/cipherscan
+++ b/cipherscan
@@ -20,6 +20,10 @@ else
     OPENSSLBIN="${REALPATH}/openssl"
 fi
 OPENSSLBINHELP="$($OPENSSLBIN s_client -help 2>&1)"
+if ! [[ $OPENSSLBINHELP =~ -connect ]]; then
+    echo "$OPENSSLBIN s_client doesn't accept the -connect parameter, which is extremely strange; refusing to proceed." 1>&2
+    exit 1
+fi
 
 # cipherscan requires bash4, which doesn't come by default in OSX
 if [[ ${BASH_VERSINFO[0]} -lt 4 ]]; then