LittleNellie/cipherscan
2
0
Fork 0
mirror of https://github.com/mozilla/cipherscan.git synced 2026-02-06 07:05:15 +01:00
Code Issues Releases Wiki Activity

fixes for "SC2046: Quote this to prevent word splitting." and "SC2086: Double quote to prevent globbing and word splitting."

Browse Source 
In cipherscan line 13:
REALPATH=$(dirname $0)
                   ^-- SC2086: Double quote to prevent globbing and word splitting.

In cipherscan line 15:
readlink -f $0 &>/dev/null && REALPATH=$(dirname $(readlink -f $0))
            ^-- SC2086: Double quote to prevent globbing and word splitting.
                                                 ^-- SC2046: Quote this to prevent word splitting.
                                                               ^-- SC2086: Double quote to prevent globbing and word splitting.

In cipherscan line 46:
if [[ -e $(dirname $0)/openssl.cnf ]]; then
                   ^-- SC2086: Double quote to prevent globbing and word splitting.

In cipherscan line 47:
    export OPENSSL_CONF="$(dirname $0)/openssl.cnf"
           ^-- SC2155: Declare and assign separately to avoid masking return values.
                                   ^-- SC2086: Double quote to prevent globbing and word splitting.

In cipherscan line 60:
    CACERTS="$(dirname $0)/ca-bundle.crt"
                       ^-- SC2086: Double quote to prevent globbing and word splitting.
This commit is contained in:
Richard Soderberg
2015-09-03 06:25:15 -07:00
parent 4405d3fdce
commit 21871b5bd7
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
cipherscan
View File

@@ -10,9 +10,9 @@
DOBENCHMARK=0 DOBENCHMARK=0
BENCHMARKITER=30 BENCHMARKITER=30
REALPATH=$(dirname $0) REALPATH=$(dirname "$0")
# make sure this doesn't error out when readlink -f isn't available (OSX) # make sure this doesn't error out when readlink -f isn't available (OSX)
readlink -f $0 &>/dev/null && REALPATH=$(dirname $(readlink -f $0)) readlink -f "$0" &>/dev/null && REALPATH=$(dirname "$(readlink -f "$0")")
OPENSSLBIN="${REALPATH}/openssl" OPENSSLBIN="${REALPATH}/openssl"
if [[ "$(uname -s)" == "Darwin" ]]; then if [[ "$(uname -s)" == "Darwin" ]]; then
OPENSSLBIN="${REALPATH}/openssl-darwin64" OPENSSLBIN="${REALPATH}/openssl-darwin64"
@@ -43,8 +43,8 @@ if [[ "$TIMEOUTOUTPUT" =~ BusyBox ]]; then
fi fi
# use custom config file to enable GOST ciphers # use custom config file to enable GOST ciphers
if [[ -e $(dirname $0)/openssl.cnf ]]; then if [[ -e $(dirname "$0")/openssl.cnf ]]; then
export OPENSSL_CONF="$(dirname $0)/openssl.cnf" export OPENSSL_CONF="$(dirname "$0")/openssl.cnf"
fi fi
# find a list of trusted CAs on the local system, or use the provided list # find a list of trusted CAs on the local system, or use the provided list
@@ -57,7 +57,7 @@ if [[ -z "$CACERTS" ]]; then
done done
fi fi
if [[ ! -e "$CACERTS" ]]; then if [[ ! -e "$CACERTS" ]]; then
CACERTS="$(dirname $0)/ca-bundle.crt" CACERTS="$(dirname "$0")/ca-bundle.crt"
fi fi
# RSA ciphers are put at the end to force Google servers to accept ECDSA ciphers # RSA ciphers are put at the end to force Google servers to accept ECDSA ciphers